----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12006/#review22183 -----------------------------------------------------------
While I agree with this change, I think it may be too late for inclusion in 0.24. I think we _could_ safely do for 0.24 would be: 1) remove the qmfv2 prototype - we can still access the code on older branches if we need to reference it 2) remove the qmf/engine stuff and it's bindings The rest - client api, qmfv1 agent and console - we should leave as-is for 0.24, _but_ 1) Mark them as deprecated in the 0.24 release notes 2) Force some sort of physical deprecation warning into the code that cannot be ignored by anyone who is using the api - an error log, thrown exception, etc - and ship that in 0.24 3) apply the remainder of this patch immediately after we branch, target for 0.26. thoughts? - Kenneth Giusti On June 20, 2013, 4:10 p.m., Andrew Stitcher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12006/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 4:10 p.m.) > > > Review request for qpid. > > > Description > ------- > > This is the outcome of a series of changes to remove much oobsolete and > deprecated code in the Qpid tree: > > This removes obsolete example code; obsolete QMFv1 code and examples. > > Finally (as a result of the above) it changes the "exported" installable > header files to be a much smaller set that only support the currently > supported Qpid APIs. > > See my github repo for a more granular version of this change as it is > intended to be committed to the Qpid source tree: > https://github.com/astitcher/qpid/commits/remove-old-api > > > This addresses bugs QPID-4940, QPID-4941 and QPID-4942. > https://issues.apache.org/jira/browse/QPID-4940 > https://issues.apache.org/jira/browse/QPID-4941 > https://issues.apache.org/jira/browse/QPID-4942 > > > Diffs > ----- > > /trunk/qpid/cpp/CMakeLists.txt 1494712 > /trunk/qpid/cpp/Makefile.am 1494712 > /trunk/qpid/cpp/bindings/CMakeLists.txt 1494712 > /trunk/qpid/cpp/bindings/qmf/Makefile.am 1494712 > /trunk/qpid/cpp/bindings/qmf/python/CMakeLists.txt 1494712 > /trunk/qpid/cpp/bindings/qmf/python/Makefile.am 1494712 > /trunk/qpid/cpp/bindings/qmf/python/python.i 1494712 > /trunk/qpid/cpp/bindings/qmf/python/qmf.py 1494712 > /trunk/qpid/cpp/bindings/qmf/ruby/CMakeLists.txt 1494712 > /trunk/qpid/cpp/bindings/qmf/ruby/Makefile.am 1494712 > /trunk/qpid/cpp/bindings/qmf/ruby/qmf.rb 1494712 > /trunk/qpid/cpp/bindings/qmf/ruby/ruby.i 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/Makefile.am 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/agent_ruby.rb 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/python_agent.py 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/python_console.py 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/ruby_console.rb 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/ruby_console_test.rb 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/run_interop_tests 1494712 > /trunk/qpid/cpp/bindings/qmf/tests/test_base.rb 1494712 > /trunk/qpid/cpp/configure.ac 1494712 > /trunk/qpid/cpp/examples/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/README.verify 1494712 > /trunk/qpid/cpp/examples/old_api/direct/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/direct/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/direct/declare_queues.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/direct/direct_declare_queues.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/direct/direct_direct_producer.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/direct/direct_listener.vcproj 1494712 > /trunk/qpid/cpp/examples/old_api/direct/direct_producer.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/direct/listener.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/direct/verify 1494712 > /trunk/qpid/cpp/examples/old_api/direct/verify.in 1494712 > /trunk/qpid/cpp/examples/old_api/failover/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/failover/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/failover/declare_queues.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/failover/failover_declare_queues.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/failover/failover_replaying_sender.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/failover/failover_resuming_receiver.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/failover/replaying_sender.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/failover/resuming_receiver.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/fanout_fanout_producer.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/fanout_listener.vcproj 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/fanout_producer.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/listener.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/verify 1494712 > /trunk/qpid/cpp/examples/old_api/fanout/verify.in 1494712 > /trunk/qpid/cpp/examples/old_api/old-examples.sln 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/pub-sub_topic_listener.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/pub-sub_topic_publisher.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/topic_listener.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/topic_publisher.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/verify 1494712 > /trunk/qpid/cpp/examples/old_api/pub-sub/verify.in 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/client.cpp 1494712 > > /trunk/qpid/cpp/examples/old_api/request-response/request-response_client.vcproj > 1494712 > > /trunk/qpid/cpp/examples/old_api/request-response/request-response_server.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/server.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/verify 1494712 > /trunk/qpid/cpp/examples/old_api/request-response/verify.in 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/declare_queues.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/topic_listener.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/topic_publisher.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/tradedemo_declare_queues.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/tradedemo_topic_listener.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/tradedemo/tradedemo_topic_publisher.vcproj > 1494712 > /trunk/qpid/cpp/examples/old_api/verify 1494712 > /trunk/qpid/cpp/examples/old_api/verify_all 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/Makefile.am 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/README.txt 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/declare_queues.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/listener.cpp 1494712 > /trunk/qpid/cpp/examples/old_api/xml-exchange/xml_producer.cpp 1494712 > /trunk/qpid/cpp/examples/qmf-console/CMakeLists.txt 1494712 > /trunk/qpid/cpp/examples/qmf-console/Makefile.am 1494712 > /trunk/qpid/cpp/examples/qmf-console/README.txt 1494712 > /trunk/qpid/cpp/examples/qmf-console/cluster-qmon.cpp 1494712 > /trunk/qpid/cpp/examples/qmf-console/console.cpp 1494712 > /trunk/qpid/cpp/examples/qmf-console/ping.cpp 1494712 > /trunk/qpid/cpp/examples/qmf-console/printevents.cpp 1494712 > /trunk/qpid/cpp/examples/qmf-console/qmf-console_console.vcproj 1494712 > /trunk/qpid/cpp/examples/qmf-console/qmf-console_ping.vcproj 1494712 > /trunk/qpid/cpp/examples/qmf-console/qmf-console_printevents.vcproj 1494712 > /trunk/qpid/cpp/examples/qmf-console/qmf-console_queuestats.vcproj 1494712 > /trunk/qpid/cpp/examples/qmf-console/queuestats.cpp 1494712 > /trunk/qpid/cpp/include/qmf/engine/Agent.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/ConnectionSettings.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Console.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Event.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Message.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Object.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/ObjectId.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/QmfEngineImportExport.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Query.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/ResilientConnection.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Schema.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Typecode.h 1494712 > /trunk/qpid/cpp/include/qmf/engine/Value.h 1494712 > /trunk/qpid/cpp/include/qmf/qmfengine.i 1494712 > /trunk/qpid/cpp/include/qpid/Address.h 1494712 > /trunk/qpid/cpp/include/qpid/CommonImportExport.h 1494712 > /trunk/qpid/cpp/include/qpid/InlineAllocator.h 1494712 > /trunk/qpid/cpp/include/qpid/InlineVector.h 1494712 > /trunk/qpid/cpp/include/qpid/Msg.h 1494712 > /trunk/qpid/cpp/include/qpid/Options.h 1494712 > /trunk/qpid/cpp/include/qpid/RangeSet.h 1494712 > /trunk/qpid/cpp/include/qpid/SessionId.h 1494712 > /trunk/qpid/cpp/include/qpid/Url.h 1494712 > /trunk/qpid/cpp/include/qpid/agent/ManagementAgent.h 1494712 > /trunk/qpid/cpp/include/qpid/agent/QmfAgentImportExport.h 1494712 > /trunk/qpid/cpp/include/qpid/amqp_0_10/Codecs.h 1494712 > /trunk/qpid/cpp/include/qpid/client/AsyncSession.h 1494712 > /trunk/qpid/cpp/include/qpid/client/ClientImportExport.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Completion.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Connection.h 1494712 > /trunk/qpid/cpp/include/qpid/client/ConnectionSettings.h 1494712 > /trunk/qpid/cpp/include/qpid/client/FailoverListener.h 1494712 > /trunk/qpid/cpp/include/qpid/client/FailoverManager.h 1494712 > /trunk/qpid/cpp/include/qpid/client/FlowControl.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Future.h 1494712 > /trunk/qpid/cpp/include/qpid/client/FutureCompletion.h 1494712 > /trunk/qpid/cpp/include/qpid/client/FutureResult.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Handle.h 1494712 > /trunk/qpid/cpp/include/qpid/client/LocalQueue.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Message.h 1494712 > /trunk/qpid/cpp/include/qpid/client/MessageListener.h 1494712 > /trunk/qpid/cpp/include/qpid/client/MessageReplayTracker.h 1494712 > /trunk/qpid/cpp/include/qpid/client/QueueOptions.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Session.h 1494712 > /trunk/qpid/cpp/include/qpid/client/SessionBase_0_10.h 1494712 > /trunk/qpid/cpp/include/qpid/client/Subscription.h 1494712 > /trunk/qpid/cpp/include/qpid/client/SubscriptionManager.h 1494712 > /trunk/qpid/cpp/include/qpid/client/SubscriptionSettings.h 1494712 > /trunk/qpid/cpp/include/qpid/client/TypedResult.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Agent.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Broker.h 1494712 > /trunk/qpid/cpp/include/qpid/console/ClassKey.h 1494712 > /trunk/qpid/cpp/include/qpid/console/ConsoleImportExport.h 1494712 > /trunk/qpid/cpp/include/qpid/console/ConsoleListener.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Event.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Object.h 1494712 > /trunk/qpid/cpp/include/qpid/console/ObjectId.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Package.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Schema.h 1494712 > /trunk/qpid/cpp/include/qpid/console/SequenceManager.h 1494712 > /trunk/qpid/cpp/include/qpid/console/SessionManager.h 1494712 > /trunk/qpid/cpp/include/qpid/console/Value.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/Array.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/Buffer.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/FieldTable.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/FieldValue.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/List.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/ProtocolVersion.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/SequenceNumber.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/SequenceSet.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/StructHelper.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/Uuid.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/amqp_types.h 1494712 > /trunk/qpid/cpp/include/qpid/framing/amqp_types_full.h 1494712 > /trunk/qpid/cpp/include/qpid/log/Logger.h 1494712 > /trunk/qpid/cpp/include/qpid/log/Options.h 1494712 > /trunk/qpid/cpp/include/qpid/log/Selector.h 1494712 > /trunk/qpid/cpp/include/qpid/log/SinkOptions.h 1494712 > /trunk/qpid/cpp/include/qpid/log/Statement.h 1494712 > /trunk/qpid/cpp/include/qpid/management/Args.h 1494712 > /trunk/qpid/cpp/include/qpid/management/Buffer.h 1494712 > /trunk/qpid/cpp/include/qpid/management/ConnectionSettings.h 1494712 > /trunk/qpid/cpp/include/qpid/management/Manageable.h 1494712 > /trunk/qpid/cpp/include/qpid/management/ManagementEvent.h 1494712 > /trunk/qpid/cpp/include/qpid/management/ManagementObject.h 1494712 > /trunk/qpid/cpp/include/qpid/management/Mutex.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Condition.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/ExceptionHolder.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/IOHandle.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Monitor.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Mutex.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Runnable.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/StrError.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/SystemInfo.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Thread.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/Time.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/posix/Condition.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/posix/Mutex.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/posix/PrivatePosix.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/posix/Time.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/posix/check.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/windows/Condition.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/windows/Mutex.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/windows/Time.h 1494712 > /trunk/qpid/cpp/include/qpid/sys/windows/check.h 1494712 > /trunk/qpid/cpp/src/CMakeLists.txt 1494712 > /trunk/qpid/cpp/src/Makefile.am 1494712 > /trunk/qpid/cpp/src/qmf.mk 1494712 > /trunk/qpid/cpp/src/qmf/engine/Agent.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/BrokerProxyImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/BrokerProxyImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ConnectionSettingsImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/ConnectionSettingsImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ConsoleImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/ConsoleImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/EventImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/EventImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/MessageImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/MessageImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ObjectIdImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/ObjectIdImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ObjectImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/ObjectImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/Protocol.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/Protocol.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/QueryImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/QueryImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ResilientConnection.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/SchemaImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/SchemaImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/SequenceManager.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/SequenceManager.cpp 1494712 > /trunk/qpid/cpp/src/qmf/engine/ValueImpl.h 1494712 > /trunk/qpid/cpp/src/qmf/engine/ValueImpl.cpp 1494712 > /trunk/qpid/cpp/src/qmfc.mk 1494712 > /trunk/qpid/cpp/src/qpid/Address.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/CommonImportExport.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/InlineAllocator.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/InlineVector.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/Msg.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/Options.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/RangeSet.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/SessionId.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/Url.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/agent/ManagementAgentImpl.h 1494712 > /trunk/qpid/cpp/src/qpid/agent/ManagementAgentImpl.cpp 1494712 > /trunk/qpid/cpp/src/qpid/amqp_0_10/Codecs.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/AsyncSession.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/ClientImportExport.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Completion.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Connection.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/ConnectionSettings.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/FailoverListener.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/FailoverManager.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/FlowControl.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Future.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/FutureCompletion.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/FutureResult.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Handle.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/LocalQueue.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Message.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/MessageListener.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/MessageReplayTracker.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/QueueOptions.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Session.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/SessionBase_0_10.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/Subscription.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/SubscriptionManager.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/SubscriptionSettings.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/client/TypedResult.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/console/Agent.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Broker.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/ClassKey.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Event.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Object.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/ObjectId.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Package.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Schema.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/SequenceManager.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/SessionManager.cpp 1494712 > /trunk/qpid/cpp/src/qpid/console/Value.cpp 1494712 > /trunk/qpid/cpp/src/qpid/framing/Array.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/Buffer.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/FieldTable.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/FieldValue.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/List.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/ProtocolVersion.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/SequenceNumber.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/SequenceSet.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/StructHelper.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/Uuid.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/amqp_types.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/framing/amqp_types_full.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/log/Logger.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/log/Options.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/log/Selector.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/log/SinkOptions.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/log/Statement.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/Args.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/Buffer.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/ConnectionSettings.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/Manageable.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/ManagementEvent.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/ManagementObject.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/management/Mutex.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Condition.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/ExceptionHolder.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/IOHandle.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Monitor.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Mutex.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Runnable.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/StrError.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/SystemInfo.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Thread.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/Time.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/Condition.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/Mutex.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/PrivatePosix.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/Time.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/check.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/windows/Condition.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/windows/Mutex.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/windows/Time.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/windows/check.h PRE-CREATION > /trunk/qpid/cpp/src/tests/CMakeLists.txt 1494712 > /trunk/qpid/cpp/src/tests/ConsoleTest.cpp 1494712 > /trunk/qpid/cpp/src/tests/Makefile.am 1494712 > /trunk/qpid/cpp/src/tests/ManagementTest.cpp 1494712 > /trunk/qpid/cpp/src/tests/testagent.cpp 1494712 > /trunk/qpid/cpp/src/tests/testagent.mk 1494712 > /trunk/qpid/cpp/src/tests/testagent.xml 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/__init__.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/agent.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/common.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/console.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/__init__.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/agent_discovery.py > 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/agent_test.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/async_method.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/async_query.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/basic_method.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/basic_query.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/console_test.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/events.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/multi_response.py > 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/obj_gets.py 1494712 > /trunk/qpid/extras/qmf/src/py/qmf2-prototype/tests/subscriptions.py 1494712 > > Diff: https://reviews.apache.org/r/12006/diff/ > > > Testing > ------- > > cmake: make; make install make test > autotools: make; make install; make check (There still seems to be a residual > warning with the perl bindings) > > > Thanks, > > Andrew Stitcher > >
