-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12029/
-----------------------------------------------------------
Review request for qpid.
Description
-------
General refactoring:
* moved qpid::broker::Connection to moved qpid::broker::amqp_0_10::Connection
* generalised (and renamed) ConnectionIdentity to protocol independent
Connection interface
- added isLink(), getClientProperties() and abort()
- merged getUrl() and getMgmtId() as they are the same thing (kept the name
of the latter)
* ConnectionObserver now observes this interface
* have Connection of publisher returned by pointer from Message since it may
not be set
* remove Message::getPublisherOwnership(), add
Message::isLocalTo(OwnershipToken*) instead
* remove Message::getPublisherUserId(), Message::getPublisherObjectId(),
Message::getPublisherUrl(); these essentially duplicate the same methods on
Connection, are used only by ManagementAgent and (particularly the latter two)
really only make sense in that context anyway and I'm keen to keep Message as
clean as possible
* LinkRegistry observer only cares about 0-10 connections
AMQP 1.0 connection hooked into notify ConnectionObservers of various events
and to request approval for connection from ACL module.
This addresses bug QPID-4712.
https://issues.apache.org/jira/browse/QPID-4712
Diffs
-----
/trunk/qpid/cpp/src/CMakeLists.txt 1494646
/trunk/qpid/cpp/src/Makefile.am 1494646
/trunk/qpid/cpp/src/qpid/broker/Bridge.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Bridge.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/Broker.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/Connection.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Connection.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.h 1494646
/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/ConnectionIdentity.h 1494646
/trunk/qpid/cpp/src/qpid/broker/HandlerImpl.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Link.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Link.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.h 1494646
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/Message.h 1494646
/trunk/qpid/cpp/src/qpid/broker/Message.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.h 1494646
/trunk/qpid/cpp/src/qpid/broker/SaslAuthenticator.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SecureConnectionFactory.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionContext.h 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.h 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionHandler.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionState.h 1494646
/trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/Connection.h 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/Interconnect.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.h 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/ManagedConnection.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/Sasl.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1494646
/trunk/qpid/cpp/src/qpid/broker/amqp_0_10/Connection.h PRE-CREATION
/trunk/qpid/cpp/src/qpid/broker/amqp_0_10/Connection.cpp PRE-CREATION
/trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1494646
/trunk/qpid/cpp/src/qpid/ha/ConnectionObserver.cpp 1494646
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.h 1494646
/trunk/qpid/cpp/src/qpid/management/ManagementAgent.cpp 1494646
Diff: https://reviews.apache.org/r/12029/diff/
Testing
-------
make check and make test pass
Thanks,
Gordon Sim
