----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12116/#review22464 -----------------------------------------------------------
Ship it! Note that the correct issue is Proton-277. - Gordon Sim On June 26, 2013, 7:04 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12116/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 7:04 p.m.) > > > Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross. > > > Bugs: proton-227 > https://issues.apache.org/jira/browse/proton-227 > > > Repository: qpid > > > Description > ------- > > Gordon's patch to allow the creation of a terminus (source/target) without an > address when the dynamic flag is true. > > > Diffs > ----- > > /proton/trunk/proton-c/src/engine/engine.c 1496140 > /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1496140 > /proton/trunk/tests/python/proton_tests/engine.py 1496140 > > Diff: https://reviews.apache.org/r/12116/diff/ > > > Testing > ------- > > New testcase added, verified for both proton-c and proton-j. > > > Thanks, > > Kenneth Giusti > >
