> On July 5, 2013, 2:20 p.m., Alan Conway wrote: > > /trunk/qpid/cpp/src/qpid/broker/Queue.h, line 126 > > <https://reviews.apache.org/r/12249/diff/1-2/?file=317951#file317951line126> > > > > Not sure what "use case" means. Is the controller a subscriber?
It could be. Right now in practical terms it is either a sending or receiving link over 1.0 and is only relevant for policy options that are currently only exposed for queues created in response to an attach with the dynamic flag set on the terminus. However in answering the question I realise I haven't set it for sending links, so will fix that. I'll see if I can come up with wording for this comment that is a clearer also. - Gordon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12249/#review22781 ----------------------------------------------------------- On July 4, 2013, 7:39 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12249/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 7:39 p.m.) > > > Review request for qpid, Alan Conway and Kenneth Giusti. > > > Bugs: QPID-4976 > https://issues.apache.org/jira/browse/QPID-4976 > > > Repository: qpid > > > Description > ------- > > This adds the ability to have queue autodeleted when no longer used, when > empty or when both no longer used and empty as specified in the standard > lifetime policies for AMQP 1.0. The ability to only delete if unused and > empty is useful for 0-10 also so I've allowed these to be set there as well. > > The basic change is to have an optional policy specified that dictates what > autodelete means. The default is to autodelete when not used. A queue is in > use if it is being consumed or browsed, or if in 0-10 it has been declared as > an exclusive queue and the declaring session is still active. Additionally > over 1.0 the queue is in use if there is any sender attached to it. > Autodeletion is now triggered automatically by the queue when some other > operation moves it to a state eligible for deletion. To avoid this on a > backup in ha, the queue replicator flags the replica as in use. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/amqp/descriptors.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/Lvq.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/Connection.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/DataReader.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/NodeProperties.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/Session.h 1499373 > /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1499373 > /trunk/qpid/cpp/src/qpid/ha/BrokerReplicator.cpp 1499373 > /trunk/qpid/cpp/src/qpid/ha/QueueReplicator.cpp 1499373 > /trunk/qpid/cpp/src/qpid/messaging/amqp/AddressHelper.cpp 1499373 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1499373 > > Diff: https://reviews.apache.org/r/12249/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
