----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ -----------------------------------------------------------
(Updated July 8, 2013, 8:40 p.m.) Review request for qpid, Andrew Stitcher and Gordon Sim. Changes ------- Implemented call points, added unit tests. Not the final story yet, I will rework based on Gordon's comments https://reviews.apache.org/r/12289/diff/1/?file=318402#file318402line48 Repository: qpid Description (updated) ------- QPID-4327: TransactionObserver interface. A plugin can set the Broker's TransactionObserverFactory to create TransactionObservers. The TransactionObserver interface is called at each point in a transactions lifecycle. Currently only allows a single TransactionObserverFactory per broker. Diffs (updated) ----- /trunk/qpid/cpp/src/qpid/broker/Broker.h 1500613 /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1500613 /trunk/qpid/cpp/src/qpid/broker/DtxAck.h 1500613 /trunk/qpid/cpp/src/qpid/broker/Queue.h 1500613 /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1500613 /trunk/qpid/cpp/src/qpid/broker/RecoveredDequeue.h 1500613 /trunk/qpid/cpp/src/qpid/broker/RecoveredEnqueue.h 1500613 /trunk/qpid/cpp/src/qpid/broker/SemanticState.cpp 1500613 /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h PRE-CREATION /trunk/qpid/cpp/src/qpid/broker/TxAccept.h 1500613 /trunk/qpid/cpp/src/qpid/broker/TxAccept.cpp 1500613 /trunk/qpid/cpp/src/qpid/broker/TxBuffer.h 1500613 /trunk/qpid/cpp/src/qpid/broker/TxBuffer.cpp 1500613 /trunk/qpid/cpp/src/qpid/broker/TxOp.h 1500613 /trunk/qpid/cpp/src/qpid/ha/HaBroker.cpp 1500613 /trunk/qpid/cpp/src/tests/CMakeLists.txt 1500613 /trunk/qpid/cpp/src/tests/Makefile.am 1500613 /trunk/qpid/cpp/src/tests/TransactionObserverTest.cpp PRE-CREATION /trunk/qpid/cpp/src/tests/TxMocks.h 1500613 /trunk/qpid/cpp/src/tests/brokertest.py 1500613 /trunk/qpid/cpp/src/tests/ha_tests.py 1500613 /trunk/qpid/cpp/src/tests/test_tools.h 1500613 Diff: https://reviews.apache.org/r/12289/diff/ Testing ------- It compiles Thanks, Alan Conway