-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10363/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher and Rafael Schloming.
Bugs: proton-212
https://issues.apache.org/jira/browse/proton-212
Repository: qpid
Description
-------
Provides wrapper functions for sprintf and vsprintf to do the right thing on
overflow and argument checking.
Despite the same names the Windows version only provides the same result in the
sunny day scenario.
Also includes cmake enforcement via a post build step to verify the qpid-proton
library doesn't inadvertently use the non-wrapped versions.
The first try checked for the symbols in the dll, but (some versions of) Visual
Studio can insert vsnprintf callouts in the dll support runtime. This version
checks each foo.obj.
Sorry about the stray tariling whitespace. I'll fix that.
Diffs
-----
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/error.c
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/object/object.c
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.h
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform.c
1502397
http://svn.apache.org/repos/asf/qpid/proton/trunk/tools/cmake/Modules/WindowsC99CheckDef.cmake
PRE-CREATION
http://svn.apache.org/repos/asf/qpid/proton/trunk/tools/cmake/Modules/WindowsC99SymbolCheck.py
PRE-CREATION
Diff: https://reviews.apache.org/r/10363/diff/
Testing
-------
windows and rhel 6
Thanks,
Cliff Jansen
