-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12875/
-----------------------------------------------------------
Review request for qpid.
Bugs: qpid-5010
https://issues.apache.org/jira/browse/qpid-5010
Repository: qpid
Description
-------
Acl.py self tests issue self.fail() calls if an expected exception is not
thrown. A proposed fix for two patterns is shown in this review.
Essentially if the expected exception is thrown then pass. If some other
exception is thrown then show it's details. If no exception is thrown then
issue the self.fail() that was in the try block. Finally, where necessary, run
the cleanup handling to recover from the exception.
Diffs
-----
trunk/qpid/cpp/src/tests/acl.py 1506161
Diff: https://reviews.apache.org/r/12875/diff/
Testing
-------
There are 222 self.fail() calls that need to be examined and two of them are
changed in this review. The rest need scrutiny and when fixed may reveal
failures in the code as in QPID-5011.
Thanks,
Chug Rolke
