----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13079/#review24279 -----------------------------------------------------------
/proton/trunk/proton-c/src/messenger/messenger.c <https://reviews.apache.org/r/13079/#comment48114> This seems incorrect: should the new value of N override the last value, or increase the last value by N? - Kenneth Giusti On July 30, 2013, 8:24 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13079/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 8:24 p.m.) > > > Review request for qpid and Rafael Schloming. > > > Bugs: proton-200 > https://issues.apache.org/jira/browse/proton-200 > > > Repository: qpid > > > Description > ------- > > This patch improves the existing credit allocation scheme used by messenger. > > Currently passes the new python tests for proton-c, still need to fix the > tests for the other test targets. > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1508023 > /proton/trunk/proton-c/include/proton/messenger.h 1508023 > /proton/trunk/proton-c/src/messenger/messenger.c 1508023 > /proton/trunk/tests/python/proton_tests/messenger.py 1508023 > > Diff: https://reviews.apache.org/r/13079/diff/ > > > Testing > ------- > > New unit tests added. Additional work necessary to get the java/jni tests to > pass, which I will do before checking in the patch. > > > Thanks, > > Kenneth Giusti > >
