----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13619/#review25238 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/Queue.cpp <https://reviews.apache.org/r/13619/#comment49533> Do you need both set and notifyRequired? It looks like set is only non-empty if notifyRequired (but I may have missed a case). - Andrew Stitcher On Aug. 16, 2013, 5:09 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13619/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 5:09 p.m.) > > > Review request for qpid and Andrew Stitcher. > > > Bugs: QPID-5078 > https://issues.apache.org/jira/browse/QPID-5078 > > > Repository: qpid > > > Description > ------- > > This change ensures that if a consumer with a filter/selector skips over a > message, then other listeners or consumers will still get notified of the > availability of that skipped message. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1514329 > > Diff: https://reviews.apache.org/r/13619/diff/ > > > Testing > ------- > > make test passes > > > Thanks, > > Gordon Sim > >
