Completely agree with everything Robbie says. Any change which causes observable behaviour change must have a JIRA.
NO-JIRA would only be appropriate for "remove empty directories" or "remove unreachable code" or things like setting subversion properties - things that have no impact on the end user. This change would seem to change observable behaviour, and I would think would definitely be something one would want to include in a release note... therefore it should have a JIRA (and I would suggest raiding one now, and commenting on it pointing to this checkin). -- Rob On 19 August 2013 13:07, Robbie Gemmell <[email protected]> wrote: > It is a change in behaviour of the component and as such deserves a JIRA. > How else are users meant to know that thigns have actually changed, so that > they can either upgrade specifically to take advantage of it, or override > it back to what it was if they for some reason wanted or needed to? > > Beyond actually informing people at the time that it has been changed, > having the JIRA allows people to more easily search later for when it > changed and exactly how, by having the the entry in the release notes and > the subversion commit info automatically posted on it when the commit is > made. People can also follow JIRAs for subsequent related change, e.g. if I > decided to just revert such a change with a matching NO-JIRA commit, how > quickly would most people notice? > > I don't think it really matters that it is in a configuration file that is > typically not changed by the user; the same is often true for the source > code and we should file JIRAs for changes to that as well. > > The NO-JIRA escape was only ever meant to signal deliberate intent not to > include a JIRA reference for things like "fix typo in README.txt" and > similar...and even those should arguably have JIRAs. > > Robbie > > On 19 August 2013 11:44, Weston M. Price <[email protected]> wrote: > > > I typically don't file a JIRA for configuration changes, especially in > the > > adapter which can be easily overriden via deployment descriptors. This is > > in the ra.xml file which is generally not modified by a user and is > > internal to the adapter itself. > > > > Could you explain why you think it's JIRA worthy? > > > > > > On Aug 19, 2013, at 6:31 AM, Robbie Gemmell <[email protected]> > > wrote: > > > > > It doesn't really seem like this change falls into NO-JIRA territory. > > > > > > Robbie > > > > > > On 17 August 2013 20:36, <[email protected]> wrote: > > > > > >> Author: wprice > > >> Date: Sat Aug 17 19:36:35 2013 > > >> New Revision: 1515037 > > >> > > >> URL: http://svn.apache.org/r1515037 > > >> Log: > > >> [NO-JIRA] Changed JCA adapter to not use ConnectionPerHandler for > > >> performance reasons > > >> > > >> Modified: > > >> qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml > > >> > > >> Modified: > > qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml > > >> URL: > > >> > > > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml?rev=1515037&r1=1515036&r2=1515037&view=diff > > >> > > >> > > > ============================================================================== > > >> --- qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml > > >> (original) > > >> +++ qpid/trunk/qpid/java/jca/rar/src/main/resources/META-INF/ra.xml > Sat > > >> Aug 17 19:36:35 2013 > > >> @@ -109,12 +109,12 @@ > > >> <config-property-type>java.lang.String</config-property-type> > > >> <config-property-value>amqp://anonymous:passwd@client > > >> > > > /test?brokerlist='tcp://localhost?sasl_mechs='PLAIN''</config-property-value> > > >> </config-property> > > >> - > > >> + > > >> <config-property> > > >> <description>Use a JMS Connection per > MessageHandler</description> > > >> > > <config-property-name>UseConnectionPerHandler</config-property-name> > > >> <config-property-type>java.lang.Boolean</config-property-type> > > >> - <config-property-value>true</config-property-value> > > >> + <config-property-value>false</config-property-value> > > >> </config-property> > > >> > > >> <outbound-resourceadapter> > > >> > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > >> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
