----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13683/#review25409 -----------------------------------------------------------
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java <https://reviews.apache.org/r/13683/#comment49820> Add @Override annotation. Not absolutely essential but worth doing if you're making other changes. - Philip Harvey On Aug. 20, 2013, 3 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13683/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2013, 3 p.m.) > > > Review request for qpid, Philip Harvey, Rob Godfrey, and Rafael Schloming. > > > Bugs: proton-375 > https://issues.apache.org/jira/browse/proton-375 > > > Repository: qpid > > > Description > ------- > > Adds an accessor to obtain the last know drain state received from the remote. > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1514351 > /proton/trunk/proton-c/include/proton/engine.h 1514351 > /proton/trunk/proton-c/src/engine/engine-internal.h 1514351 > /proton/trunk/proton-c/src/engine/engine.c 1514351 > > /proton/trunk/proton-j/proton-api/src/main/java/org/apache/qpid/proton/engine/Link.java > 1514351 > /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1514351 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/LinkImpl.java > 1514351 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/TransportReceiver.java > 1514351 > > /proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/TransportSender.java > 1514351 > /proton/trunk/tests/python/proton_tests/engine.py 1514351 > > Diff: https://reviews.apache.org/r/13683/diff/ > > > Testing > ------- > > Unit test updated, passes for both proton-c and proton-j. > > > Thanks, > > Kenneth Giusti > >
