----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13902/#review25792 -----------------------------------------------------------
Ship it! Ship It! - Darryl Pierce On Aug. 30, 2013, 12:05 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13902/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 12:05 p.m.) > > > Review request for qpid, Darryl Pierce and Rafael Schloming. > > > Bugs: QPID-5104 > https://issues.apache.org/jira/browse/QPID-5104 > > > Repository: qpid > > > Description > ------- > > A present the dict return by msg.properties when using the swigged python > library, will return a copy of the properties. Modifying this has no effect > on the message properties as set. This proposal instead returns a custom > object that looks like a dict, but on setting a value it will copy that value > to the underlying c++ message object. > > > Diffs > ----- > > /trunk/qpid/cpp/bindings/qpid/python/python.i 1518236 > /trunk/qpid/python/qpid/tests/messaging/message.py 1518236 > > Diff: https://reviews.apache.org/r/13902/diff/ > > > Testing > ------- > > Tested spout/drain with -P option; added simple test using > 'msg.properties["key"] = value' pattern. > > > Thanks, > > Gordon Sim > >
