-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13652/
-----------------------------------------------------------

(Updated Sept. 5, 2013, 7:38 p.m.)


Review request for qpid, Philip Harvey, Rob Godfrey, and Rafael Schloming.


Changes
-------

Resynced to latest trunk.
Equivalent changes made to the Java impl.


Bugs: proton-401
    https://issues.apache.org/jira/browse/proton-401


Repository: qpid


Description
-------

This patch addresses proton-401.  It introduces changes to the behavior of the 
pn_link_drain()/pn_link_drained() interfaces.

Please double-check the new values returned by pn_link_credit() in the patched 
tests - these make sense to me, but I'd like confirmation.


Diffs (updated)
-----

  /proton/trunk/proton-c/src/engine/engine.c 1520110 
  /proton/trunk/proton-c/src/transport/transport.c 1520110 
  
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/SenderImpl.java
 1520110 
  
/proton/trunk/proton-j/proton/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java
 1520110 
  /proton/trunk/tests/python/proton_tests/engine.py 1520110 

Diff: https://reviews.apache.org/r/13652/diff/


Testing
-------

python tests updated to reflect changes in the credit handling.   New test 
added to verify fix.


Thanks,

Kenneth Giusti

Reply via email to