[ 
https://issues.apache.org/jira/browse/QPID-5037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777453#comment-13777453
 ] 

Robbie Gemmell commented on QPID-5037:
--------------------------------------

I would possibly consider putting the default number of displayed rows back to 
10 rather than 25, users can increase if it they like, but having it at 25 
means you need to scroll down a lot to see the Download button and the 
navigation buttons.

'Download' implies downloading what you see, possibly it should say 'Download 
Log Files'?

The 'Clear' button in the 'Set Filter' button should possibly say 'Clear 
Filter' for consistency with the 'Clear Filter' button on the toolbar. Ditto 
'Filter' vs 'Set Filter'.
We ask to confirm after hitting 'Clear' in the 'Set Filter' dialog (after an 
apparently arbitrary number of 5 filters is added?)...but we dont ask the same 
confirmation for the 'Clear Filter' button on the toolbar. We should probably 
always ask, or never ask.

EnhancedFilter.js:
===================
rc doesnt appear to be used otherwise, and isnt set if 
ruleCountToConfirmClearFilter isnt passed in args, but 
ruleCountToConfirmClearFilter is set?

+ var rc = this.ruleCountToConfirmClearFilter = 
args.ruleCountToConfirmClearFilter;
+ if(rc === undefined){
+ this.ruleCountToConfirmClearFilter = 5;

                
> [Java Broker- Web Management Console] Move log viewer into a separate tab and 
> add abilities to download logs and filter log entries in the logs table
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-5037
>                 URL: https://issues.apache.org/jira/browse/QPID-5037
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Alex Rudyy
>            Assignee: Alex Rudyy
>             Fix For: 0.25
>
>
> Move the log viewer functionality from the Broker tab to its own separate tab 
> launched from the broker tab.
> Add the following functionality into log viewer:
> # Ability to download the log files
> # Ability for sorting, filtering 
> # Use of colors to make more visual those rows which meet predefined 
> conditions (e.g. WARN, ERROR messages)
> # Allow dynamic changing of displayed columns

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to