----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14408/#review26520 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On Sept. 30, 2013, 6:56 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14408/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2013, 6:56 p.m.) > > > Review request for qpid and Gordon Sim. > > > Bugs: QPID-5196 > https://issues.apache.org/jira/browse/QPID-5196 > > > Repository: qpid > > > Description > ------- > > If a misspelled connection option is present on the command line then > hello_world.cpp throws. Since the connection constructor is outside the > try-catch block the program core dumps. > > The fix is to move the connection constructor inside the try-catch. > > > Diffs > ----- > > trunk/qpid/cpp/examples/messaging/hello_world.cpp 1527685 > > Diff: https://reviews.apache.org/r/14408/diff/ > > > Testing > ------- > > There is no test for hello_world. With this fix both linux and windows > versions print useful error messages and exit with error status. > > > Thanks, > > Chug Rolke > >
