> On Oct. 1, 2013, 6:47 p.m., Fraser Adams wrote: > > Ship It! > > Fraser Adams wrote: > Hi Alan, I've been tied up for ages on a bunch of other things so I > probably won't get a change to "fire it up" until the weekend to actually > kick it, however I have had a look through the diffs and it all looks fine to > me. > > I have to say that I'm impressed by how thorough you've been. I did a > double take when I saw the GetOpt helper mentioned cause I couldn't recall it > having any such dependencies - but you've even tidied up references that were > just mentioned as comments - nice one! > > As long as you've fired up the GUI and checked the other bits of > "durable" still behave (and from the diff I can't see any reason why they > wouldn't) then I'm cool, but it'd definitely be good to double check - that > expansion animation was a little fiddly :-) Visually though it looks fine to > me. > >
Great. I will try to figure out how to fire up the GUI myself, if you don't get to it first. - Alan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14361/#review26572 ----------------------------------------------------------- On Oct. 1, 2013, 7:46 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14361/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 7:46 p.m.) > > > Review request for qpid, Fraser Adams and rajith attapattu. > > > Bugs: QPID-5197 > https://issues.apache.org/jira/browse/QPID-5197 > > > Repository: qpid > > > Description > ------- > > QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in java > code. > QPID-5197: Remove obsolete --cluster-durable/persistLastNode options in C++ > and python. > > Fraser, can you look at the Java part of this and see if it is correct? > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/client/QueueOptions.h 1528082 > /trunk/qpid/cpp/src/qpid/client/QueueOptions.cpp 1528082 > /trunk/qpid/cpp/src/tests/QueueOptionsTest.cpp 1528082 > > /trunk/qpid/doc/book/src/cpp-broker/Cheat-Sheet-for-configuring-Queue-Options.xml > 1528082 > /trunk/qpid/doc/book/src/cpp-broker/Managing-CPP-Broker.xml 1528082 > > /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/messaging/address/QpidQueueOptions.java > 1528082 > /trunk/qpid/tools/src/java/bin/qpid-web/web/qmf-ui/scripts/qmf-ui.js > 1528082 > /trunk/qpid/tools/src/java/bin/qpid-web/web/ui/qmf.html 1528082 > > /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/tools/QpidConfig.java > 1528082 > > /trunk/qpid/tools/src/java/src/main/java/org/apache/qpid/qmf2/util/GetOpt.java > 1528082 > /trunk/qpid/tools/src/py/qpid-config 1528082 > > Diff: https://reviews.apache.org/r/14361/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
