[ https://issues.apache.org/jira/browse/QPID-5138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788077#comment-13788077 ]
Keith Wall commented on QPID-5138: ---------------------------------- Hi Alex I have only two further comments: 1. In ListTimeZones, the call to getDisplayName hardcodes arg 1 to true. I believe this will mean we always return the summer form of the timezone abbreviation (e.g. BST rather than GMT). I think we need to pass the result of tz.inDaylightTime(new Date(currentTime)) instead. 2. As discussed, there is a defect that will manifest as we transition to/from daylight saving. This occurs because the system is computing timezone information w.r.t now rather than the datetime being considered. To give an example. if I were to view a message from yesterday, and we'd just entered winter time that morning, the timestamp on the message would appear to be one hour out. > [Java Broker] Implement web management console preferences > ---------------------------------------------------------- > > Key: QPID-5138 > URL: https://issues.apache.org/jira/browse/QPID-5138 > Project: Qpid > Issue Type: New Feature > Components: Java Broker > Reporter: Alex Rudyy > Assignee: Keith Wall > Fix For: 0.25 > > > Add ability to set user preferences in web management console as specified > [here|http://cwiki.apache.org/confluence/display/qpid/Java+Broker+Design+-+Preferences] -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org