----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14599/#review26931 -----------------------------------------------------------
Ship it! Just needs a little clarification regarding the use of pn_link_set_drain() vs pn_link_drain(). Otherwise, looks good. /proton/trunk/proton-c/include/proton/engine.h <https://reviews.apache.org/r/14599/#comment52449> I find this confusing - under what circumstances should an app invoke 'pn_link_set_drain(..., True)' vs. just calling 'pn_link_drain()'? What is the intent of each method call? /proton/trunk/proton-c/src/engine/engine.c <https://reviews.apache.org/r/14599/#comment52447> - Kenneth Giusti On Oct. 11, 2013, 2:22 p.m., Rafael Schloming wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14599/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 2:22 p.m.) > > > Review request for qpid and Kenneth Giusti. > > > Bugs: PROTON-200 > https://issues.apache.org/jira/browse/PROTON-200 > > > Repository: qpid > > > Description > ------- > > Updated patch for PROTON-200. > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1531280 > /proton/trunk/proton-c/include/proton/engine.h 1531280 > /proton/trunk/proton-c/include/proton/messenger.h 1531280 > /proton/trunk/proton-c/src/engine/engine-internal.h 1531280 > /proton/trunk/proton-c/src/engine/engine.c 1531280 > /proton/trunk/proton-c/src/messenger/messenger.c 1531280 > /proton/trunk/proton-c/src/util.h 1531280 > /proton/trunk/tests/python/proton_tests/messenger.py 1531280 > > Diff: https://reviews.apache.org/r/14599/diff/ > > > Testing > ------- > > > Thanks, > > Rafael Schloming > >
