Keith Wall created QPID-5240:
--------------------------------
Summary: [Java Broker] ExternalAuthenticationManager NPEs/abruptly
closes connection when connection attempt made by misconfigured client
Key: QPID-5240
URL: https://issues.apache.org/jira/browse/QPID-5240
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Keith Wall
Priority: Minor
The Jenkins CI logs from the ExternalAuthenticationTests show that when the
external auth is used by a mis-configured client (client without keystore,
client using non-ssl, etc), the Broker logs a NPE and abruptly closes the
connection. The Broker should handle this scenario cleanly and log a useful
warning Broker side.
Log from testExternalAuthenticationManagerWithoutClientKeyStore
{noformat}
IoReceiver - /127.0.0.1:37985 2013-10-16 01:06:19,664 ERROR
[server.protocol.v0_8.AMQProtocolEngine] Unexpected exception while processing
frame. Closing connection.
java.lang.NullPointerException
at
org.apache.qpid.server.security.auth.sasl.external.ExternalSaslServer.getAuthorizationID(ExternalSaslServer.java:65)
at
org.apache.qpid.server.security.SubjectCreator.authenticate(SubjectCreator.java:93)
at
org.apache.qpid.server.protocol.v0_8.handler.ConnectionStartOkMethodHandler.methodReceived(ConnectionStartOkMethodHandler.java:81)
at
org.apache.qpid.server.protocol.v0_8.handler.ServerMethodDispatcherImpl.dispatchConnectionStartOk(ServerMethodDispatcherImpl.java:436)
at
org.apache.qpid.framing.amqp_0_9.ConnectionStartOkBodyImpl.execute(ConnectionStartOkBodyImpl.java:130)
at
org.apache.qpid.server.protocol.v0_8.state.AMQStateManager.methodReceived(AMQStateManager.java:120)
at
org.apache.qpid.server.protocol.v0_8.AMQProtocolEngine.methodFrameReceived(AMQProtocolEngine.java:578)
at
org.apache.qpid.framing.AMQMethodBodyImpl.handle(AMQMethodBodyImpl.java:97)
at
org.apache.qpid.server.protocol.v0_8.AMQProtocolEngine.frameReceived(AMQProtocolEngine.java:442)
at
org.apache.qpid.server.protocol.v0_8.AMQProtocolEngine.dataBlockReceived(AMQProtocolEngine.java:365)
at
org.apache.qpid.server.protocol.v0_8.AMQProtocolEngine.received(AMQProtocolEngine.java:286)
at
org.apache.qpid.server.protocol.v0_8.AMQProtocolEngine.received(AMQProtocolEngine.java:104)
at
org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:131)
at
org.apache.qpid.server.protocol.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:47)
at
org.apache.qpid.transport.network.io.IoReceiver.run(IoReceiver.java:161)
at java.lang.Thread.run(Thread.java:722)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
