----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14911/#review27515 -----------------------------------------------------------
Ship it! Ship It! - Gordon Sim On Oct. 24, 2013, 7:54 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14911/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2013, 7:54 p.m.) > > > Review request for qpid, Gordon Sim, mick semb wever, and mick goulish. > > > Bugs: QPID-4287 > https://issues.apache.org/jira/browse/QPID-4287 > > > Repository: qpid > > > Description > ------- > > QPID-4287: Poor performance when a priority queue with a ring queue policy > has a large backlog > > LossyQueue::checkDepth was performing an unintended linear search of its > messages when a new message was added at capacity. Since the messages are in > priority order, only the tail message on the queue needs to be compared with > the > new message to determine which of them should be dropped. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/LossyQueue.cpp 1535398 > /trunk/qpid/cpp/src/qpid/broker/Queue.h 1535398 > /trunk/qpid/cpp/src/qpid/broker/Queue.cpp 1535398 > > Diff: https://reviews.apache.org/r/14911/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
