[
https://issues.apache.org/jira/browse/QPID-5207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806481#comment-13806481
]
Keith Wall commented on QPID-5207:
----------------------------------
Looks good. A couple of minor comments only:
1) DojoHelper static initialiser should close the InputStream in a finally.
2) DojoHelper method readPropertyValue is unnecessary - use
Properties.getProperty(key, defaultValue) instead
3) FileServlet constructors - could one chain the other e.g.
this(RESOURCES_PREFIX, false).
4) FileServlet is used like a singleton and instances are constructed. I'd do
away with FileServlet.INSTANCE and create an instance from the default
constructor in HttpManagement for .js's, html's etc.
5) To support users utilising a web.xml, does FileServlet need to provide an
alternative method for the initialisation resourcePathPrefix and usePathInfo
(ServletConfig#getInitParameter etc). Not sure if we care about this atm?
Thanks, Keith.
> [Java Broker] use the Dojo release binary for the management-http plugin
> build instead of extracting the war
> ------------------------------------------------------------------------------------------------------------
>
> Key: QPID-5207
> URL: https://issues.apache.org/jira/browse/QPID-5207
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.25
>
>
> The build process for the management-http plugin currently extracts some of
> the Dojo war into its jar file during its build process. This process is very
> slow in certain platforms and environments. In order to remove this overhead,
> and also simplify the dependency process, we should use the dojo release zip
> directly instead.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
