[
https://issues.apache.org/jira/browse/QPID-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809658#comment-13809658
]
ASF subversion and git services commented on QPID-4534:
-------------------------------------------------------
Commit 1537313 from [~k-wall] in branch 'qpid/trunk'
[ https://svn.apache.org/r1537313 ]
QPID-4534: unify client heartbeat system properties/connection url options.
* Connection url 'heartbeat' broker-option (and deprecated 'idle_timeout') now
understood for all protocols
* System property 'qpid.heartbeat' (and deprecated 'amqj.heartbeat.delay' and
'idle_timeout') now understood for all protocols
* Enhanced heartbeat system tests
* Docbook updates
Original patch from Keith Wall, plus updates from Robbie Gemmell
> Unify client side heartbeat system properties/broker url options
> -----------------------------------------------------------------
>
> Key: QPID-4534
> URL: https://issues.apache.org/jira/browse/QPID-4534
> Project: Qpid
> Issue Type: Improvement
> Components: Documentation, Java Client
> Reporter: Keith Wall
> Assignee: Keith Wall
> Attachments:
> 0001-QPID-4534-unify-client-heartbeat-system-properties-c.patch,
> 0001-QPID-4534-Unify-client-side-heartbeat-system-propert.patch
>
>
> The heartbeat controls/defaults offered by the 0-10 Java client are different
> and to those used by the 0-8..0-9-1. This has the potential to confuse the
> end-user and makes clear documentation more difficult.
> The current situation looks like this:
> The 0-10 codepath defaults heart-beating to enabled with a period of 120s.
> It may be configured on the client side by either:
> * broker url option ?heartbeat=... (value in secs)
> * system properties qpid.heartbeat (value in secs), amqj.heartbeat.delay
> (secs), idle_timeout (ms). The latter two are considered deprecated.
> The 0-8..0-9-1 codepath defaults heart-beating to disabled. It may be
> enabled on the client side using the system property amqj.heartbeat.delay.
> In the Java Broker's implementation of 0-8..0-9-1 allows heartbeating to be
> enabled from the server side, by a mechanism where the server proposes a
> heartbeat value to the client, and the client can either accept the value or
> put forward its own. The client does not understand the broker url option
> 'heartbeat' nor the newer system property qpid.heartbeat.
> The Programming in Apache Qpid docbook reflects the 0-10 behaviour and makes
> no mention to the differences in the other protocols.
> The intention is to change the code as follows:
> # make both code paths understand the qpid.heartbeat system property.
> amqj.heartbeat.delay will continue to be supported as deprecated.
> # make the broker url option heartbeat=... will be understood by both code
> paths
> # update docbook
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
