----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15083/#review28009 -----------------------------------------------------------
Ship it! Very nice addition to qpid-config! One *minor* nit - I didn't see the "list" option listed in the qpid-config --help usage summary. Otherwise, ship it! - Kenneth Giusti On Nov. 1, 2013, 12:45 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15083/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 12:45 p.m.) > > > Review request for qpid, Justin Ross, Kenneth Giusti, Jakub Scholz, and Ted > Ross. > > > Bugs: QPID-5277 > https://issues.apache.org/jira/browse/QPID-5277 > > > Repository: qpid > > > Description > ------- > > The qpid-config utilty currently allows queues, exchanges and bindings to be > created, but doesn't support other types. > > Having a generic mechanism for create, delete and list would be very useful > as it would mean the tool could be used for any entity types added (even if > optional). Specifically this would eliminate the need for the current qpidt > test utility in managing the various new 1.0 related entities. > > With attached patch you can do e.g. > > qpid-config add domain my-domain --argument url=localhost:6666 > qpid-config list domain > qpid-config del domain > > The existing functions and options of qpid-config are not altered. > > > Diffs > ----- > > /trunk/qpid/tools/src/py/qpid-config 1537889 > /trunk/qpid/tools/src/py/qpidtoollibs/broker.py 1537889 > > Diff: https://reviews.apache.org/r/15083/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
