On 10/29/2013 09:31 PM, Andrew Stitcher (JIRA) wrote:>
[ https://issues.apache.org/jira/browse/QPID-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808477#comment-13808477 ]Andrew Stitcher edited comment on QPID-5237 at 10/29/13 9:31 PM: ----------------------------------------------------------------- I've made the c++ tree self contained by copying in the 3 things that were being used that were external: * The version file (QPID_VERSION.txt) * The xml specification of amqp 0-10 used to generate its framing code * The xml specification of the broker management object model Note these are now duplicated and so if changed will need to be updated in multiple places. In practice I expect this only to matter for the version file, which is already effectively duplicated in several (many?) places in the java tree. The amqp 0-10 spec is effectively fixed anyway, and the broker management schema seems only to be used in the C++ tree (although the java broker must duplicate some of the effect even if it is not actually generating code from the spec.)
I realise after tracking this down that you did comment in JIRA, but to me this would have warranted at least a brief email direct to the list (since JIRA comments are easy to miss, at least in my experience). I think its a bad idea to have duplicated files. For the management spec in particular this is bound to lead to confusion, especially since it hasn't been clearly highlighted. I already spent some time trying to figure out why changes to the spec had no effect. The java broker no longer uses this. However I'm not sure whether the Java based QMF API does? If it does then having two separate copies is not in my view acceptable and moving it without checking what works for the other component seems unreasonable. If it doesn't then I personally don't mind having this moved to the cpp tree, but lets remove the other copy to avoid confusion. --Gordon. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
