----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15757/#review29226 -----------------------------------------------------------
Ship it! This change is valuable and will provide *some* protection against having more than one broker with the same federation tag. However, there are still pathological cases this will not detect. For example: A - B - A - C. Since no two brokers with the same tag are connected, the problem will not be detected. - Ted Ross On Nov. 21, 2013, 5:27 a.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15757/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 5:27 a.m.) > > > Review request for qpid. > > > Bugs: QPID-5370 > https://issues.apache.org/jira/browse/QPID-5370 > > > Repository: qpid > > > Description > ------- > > as this can affect routing, see e.g. > http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019 > > Diff: https://reviews.apache.org/r/15757/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
