-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15818/
-----------------------------------------------------------
Review request for qpid, Justin Ross and Steve Huston.
Bugs: qpid-5307
https://issues.apache.org/jira/browse/qpid-5307
Repository: qpid
Description
-------
QPID-5307: brokertest framework: remove dependencies on environment scripts.
The following improvements have been made to the brokertest.py framework,
and the ha_tests.py test module has been updated to take advantage:
- Tests are standard python unittest modules can be run via qpid-python-test or
any python test runner
- Test modules are also executable scripts, they run themselves via
qpid-python-test and accept all arguments that qpid-python-test does.
- No environment settings are required to run the tests, test_env.sh and
test_env.ps1 are not required.
- Configuration formerly in the test_env scripts is provided in test_config.py
- Only requirement to run tests is that the current directory:
- contains a test_config.py script
- is writable so the tests can create output directories.
- CMake generates a test_config.py suitable for running tests against a qpid
build.
TODO:
- Verify ha_tests.py runs under windows.
- Generate a test_config.py to run tests run against a qpid install.
- Restore windows store configuration removed temporarily.
- Convert some existing .sh/.ps1 script tests to a new test module as examples.
Diffs
-----
/trunk/qpid/cpp/src/tests/CMakeLists.txt 1544228
/trunk/qpid/cpp/src/tests/brokertest.py 1544228
/trunk/qpid/cpp/src/tests/ha_test.py 1544228
/trunk/qpid/cpp/src/tests/ha_tests.py 1544228
/trunk/qpid/cpp/src/tests/test_config.py.in PRE-CREATION
Diff: https://reviews.apache.org/r/15818/diff/
Testing
-------
ha_tests.py passing
Thanks,
Alan Conway
