----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16018/#review29765 -----------------------------------------------------------
I can see no actual justification for this change in either the review comments or the refered bug: There is nothing per se wrong with this change, I just don't really understand why it necessary. Incidentally '/' works perfectly well as a path separator on windows too (even if it is not the default). It is true that the test for an absolute path would be different though. /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp <https://reviews.apache.org/r/16018/#comment57241> "aclFile+dataDir" looks backwards. Even this is actually correct it is going to cause confusion. - Andrew Stitcher On Dec. 4, 2013, 10:06 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16018/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 10:06 p.m.) > > > Review request for qpid, Andrew Stitcher and Steve Huston. > > > Bugs: QPID-5307 > https://issues.apache.org/jira/browse/QPID-5307 > > > Repository: qpid > > > Description > ------- > > QPID-5307: Added portable Path, check for isAbsolute() > > qpid::sys::Path provides some basic operations on path names, > with implementations for posix and windows. > > Needed by work on a portable test system. > > > Diffs > ----- > > /trunk/qpid/cpp/src/CMakeLists.txt 1546628 > /trunk/qpid/cpp/src/qpid/acl/AclPlugin.cpp 1546628 > /trunk/qpid/cpp/src/qpid/sys/Path.h PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/posix/Path.cpp PRE-CREATION > /trunk/qpid/cpp/src/qpid/sys/windows/Path.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16018/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
