-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16084/
-----------------------------------------------------------

Review request for qpid and Rafael Schloming.


Bugs: proton-475
    https://issues.apache.org/jira/browse/proton-475


Repository: qpid


Description
-------

See bug link.

This patch unfortunately changes the behavior of the API, and could break 
existing code.  The following methods are affected:

Transport.idle_timeout - value now in seconds (was msecs)
Transport.remote_idle_timeout - ditto
Transport.tick(now) - "now" changed to seconds since Epoch (was msecs)
Driver.wait(timeout) - timeout now in seconds (was msecs)

This change is consistent with the traditional use of time and timeouts under 
Python.


Diffs
-----

  /proton/trunk/proton-c/bindings/python/proton.py 1548123 
  /proton/trunk/tests/python/proton_tests/engine.py 1548123 

Diff: https://reviews.apache.org/r/16084/diff/


Testing
-------

unit tests


Thanks,

Kenneth Giusti

Reply via email to