----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16218/#review30342 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Dec. 12, 2013, 6:32 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16218/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 6:32 p.m.) > > > Review request for qpid, Justin Ross and Rafael Schloming. > > > Bugs: qpid-477 > https://issues.apache.org/jira/browse/qpid-477 > > > Repository: qpid > > > Description > ------- > > Prevents multiple distinct python SASL and SSL instances referencing the same > underlying C object. > > Also cleaned up a few no-brainer errors found by pylint. > > Modified __new__ rather than taking the wrapper approach, as both classes > export "enums", which (I think) can't be modeled using a wrapper function. > Also avoided decorators in order to support python versions < 2.6 > > > Diffs > ----- > > /proton/trunk/proton-c/bindings/python/proton.py 1549639 > /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1549639 > /proton/trunk/tests/python/proton_tests/sasl.py 1549639 > /proton/trunk/tests/python/proton_tests/ssl.py 1549639 > > Diff: https://reviews.apache.org/r/16218/diff/ > > > Testing > ------- > > two new unit tests added. > > > Thanks, > > Kenneth Giusti > >
