[
https://issues.apache.org/jira/browse/QPID-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869554#comment-13869554
]
Keith Wall commented on QPID-5065:
----------------------------------
Hi Andrew
A couple of comments:
1) Doesn't the addition of QpidTestCase#_isWindows mean that
QpidBrokerTestCase#IS_OS_WINDOWS becomes redundant.
2) In LoggingManagementFacade#copyFile() should we not check the r.v. from
FileChannel#transferFrom. How is copyFile different from
FileUtils#copyFile??
3) LoggingManagementFacade .. System.getProperty("os.name") should guard
against null. Perhaps isWindows should move to a common place?? Imports
reorder makes diff large.
4) JsonFileConfigStore#getFileLock(), bracing (code style). Also what is the
reason for the exception handing change?
5) SpawnedBrokerHolder#doWindowsKill - add some comments/use smaller methods to
explain what is going on
> [Java] tests do not run on Windows
> ----------------------------------
>
> Key: QPID-5065
> URL: https://issues.apache.org/jira/browse/QPID-5065
> Project: Qpid
> Issue Type: Task
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Attachments:
> 0001-QPID-5065-initial-windows-run-changes-for-systests-a.patch,
> TestsOnWindows.patch
>
>
> ant test does not work on windows due to assumptions about Paths, as well as
> reliance on UNIX/Linux process semantics
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
