----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16962/ -----------------------------------------------------------
Review request for qpid, Ernie Allen and Gordon Sim. Bugs: https://issues.apache.org/jira/browse/QPID-5485 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5485 Repository: qpid Description ------- When deleting a paged queue, the broker does not delete the underlying file it created in /var/lib/qpidd directory. The patch is quite trivial but worth to review from threading point of view as I have no experience in the area. Diffs ----- /trunk/qpid/cpp/src/qpid/broker/PagedQueue.h 1558751 /trunk/qpid/cpp/src/qpid/broker/PagedQueue.cpp 1558751 /trunk/qpid/cpp/src/qpid/sys/MemoryMappedFile.h 1558751 /trunk/qpid/cpp/src/qpid/sys/posix/MemoryMappedFile.cpp 1558751 /trunk/qpid/cpp/src/qpid/sys/windows/MemoryMappedFile.cpp 1558751 Diff: https://reviews.apache.org/r/16962/diff/ Testing ------- file successfully removed when following scenario in QPID-5485 Thanks, Pavel Moravec
