-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17329/
-----------------------------------------------------------

(Updated Jan. 27, 2014, 1:33 p.m.)


Review request for qpid, Gordon Sim and Rafael Schloming.


Changes
-------

Do not deallocate endpoint while it is on the "modified" list.


Bugs: proton-489
    https://issues.apache.org/jira/browse/proton-489


Repository: qpid


Description
-------

Prior to this fix, freeing an endpoint would leave stale pointers in referring 
objects.  This fix makes use of the object reference functionality to ensure an 
endpoint is only removed when all references to it are dropped.


Diffs (updated)
-----

  /proton/trunk/proton-c/include/proton/object.h 1560765 
  /proton/trunk/proton-c/src/engine/engine.c 1560765 
  /proton/trunk/proton-c/src/messenger/messenger.c 1560765 
  /proton/trunk/proton-c/src/object/object.c 1560765 
  /proton/trunk/proton-c/src/transport/transport.h 1560765 
  /proton/trunk/proton-c/src/transport/transport.c 1560765 

Diff: https://reviews.apache.org/r/17329/diff/


Testing
-------

Unit tests, including valgrind tests.


Thanks,

Kenneth Giusti

Reply via email to