[ 
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884243#comment-13884243
 ] 

Andrew Stitcher commented on QPID-5485:
---------------------------------------

Patch 2 is what I'd be thinking of.

Note you have left a debug log in there with your name in it:

+    QPID_LOG(notice, "PavelM: pagingDir=" << pagingDir);

Also in patch 2 you still need to change the open flags from O_EXCL to O_TRUNC 
which isn't in the patch.

To avoid the lock file being created at all we could also add in the ::mkdir() 
from patch 1 and stop the Broker class from trying to create the page file dir 
at all.

(I can't see these bits in your patch though so it's hard to see exactly what 
that change would be)


>  Deleting paged queue does not remove underlying file
> -----------------------------------------------------
>
>                 Key: QPID-5485
>                 URL: https://issues.apache.org/jira/browse/QPID-5485
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.24
>         Environment: (any posix system)
>            Reporter: Pavel Moravec
>            Assignee: Pavel Moravec
>            Priority: Minor
>              Labels: easyfix, easytest, patch
>             Fix For: 0.27
>
>         Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
>
>
> Description of problem:
> When deleting a paged queue, the broker does not delete the underlying file 
> it created in /var/lib/qpidd directory.
> Version-Release number of selected component (if applicable):
> MRG-M 3.0 EA (qpid-cpp 0.22-29)
> How reproducible:
> 100%
> Steps to Reproduce:
> 0. service qpiddd restart
> 1. qpid-send -a "PagedQueue; {create:always, delete:always, node: { 
> x-declare: {arguments: {'qpid.paging':'True' }}}}"
> 2. file /var/lib/qpidd/PagedQueue 
> Actual results:
> /var/lib/qpidd/PagedQueue: data
> Expected results:
> /var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such 
> file or directory)
> Additional info:



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to