----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17522/#review33218 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Jan. 30, 2014, 1:57 a.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17522/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 1:57 a.m.) > > > Review request for qpid and Rafael Schloming. > > > Bugs: proton-500 > https://issues.apache.org/jira/browse/proton-500 > > > Repository: qpid > > > Description > ------- > > Update the ctest configuration to run valgrind on the C unit tests, if it is > available. > > Tests that are not valgrind-clean by design - should we want them - can > simply leave the ${memcheck-cmd} directive out of the add_test() command. > > > Diffs > ----- > > /proton/trunk/proton-c/src/tests/CMakeLists.txt 1562224 > /proton/trunk/proton-c/src/tests/message.c 1562224 > > Diff: https://reviews.apache.org/r/17522/diff/ > > > Testing > ------- > > ran the tests both with and without valgrind enabled. > > > Thanks, > > Kenneth Giusti > >
