----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17587/ -----------------------------------------------------------
(Updated Jan. 31, 2014, 3:50 p.m.) Review request for qpid and Kim van der Riet. Changes ------- New patch version uploaded (in fact verified Kim's patch I received with corrected typo). It applies Kim's comment and works well. Bugs: https://issues.apache.org/jira/browse/QPID-5530 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/QPID-5530 Repository: qpid Description ------- Processing DTX enqueue, dequeue and abort, self.__emap is empty map everytime. Hence executing: def _abort(self, xid): """Perform an abort operation for the given xid record""" for fid, hdr, lock in self.__map[xid]: if isinstance(hdr, jrnl.DeqRec): self.__emap.unlock(hdr.deq_rid) del self.__map[xid] raises error in unmap. Though I did not understand full logic of emap / map in janal.py, the extra condition in _abort prevents raising the error and allows proper processing of the abort. Diffs (updated) ----- /trunk/qpid/tools/src/py/qpidstore/janal.py 1562852 Diff: https://reviews.apache.org/r/17587/diff/ Testing ------- Thanks, Pavel Moravec
