----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17521/#review33574 -----------------------------------------------------------
Ship it! Looks good, thanks for fixing this Cliff! http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp <https://reviews.apache.org/r/17521/#comment63108> qpid/messaging/ConnectionOptions.h would be nicer, but I'm really picking nits there :-) - Gordon Sim On Feb. 4, 2014, 8:41 a.m., Cliff Jansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17521/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 8:41 a.m.) > > > Review request for qpid. > > > Bugs: QPID-5524 > https://issues.apache.org/jira/browse/QPID-5524 > > > Repository: qpid > > > Description > ------- > > Same logic as the 0-10 client once the connection option is located. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.h > 1564226 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionContext.cpp > 1564226 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/SslTransport.cpp > 1564226 > > http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/messaging/amqp/TransportContext.h > 1564226 > > Diff: https://reviews.apache.org/r/17521/diff/ > > > Testing > ------- > > Linux. > > > Thanks, > > Cliff Jansen > >
