----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17592/#review33613 -----------------------------------------------------------
/trunk/qpid/cpp/src/qpid/broker/DtxManager.h <https://reviews.apache.org/r/17592/#comment63149> This doesn't look right. Though I believe C++11 allows you to delegate to another constructor, I don't think this is the right syntax. In any case I think we want something that works for older compilers. Why not just keep one constructor but add a default value for the second parameter: DtxManager(sys::Timer&, uint32_t _dtxDefaultTimeout=0); - Gordon Sim On Feb. 4, 2014, 2:15 p.m., Pavel Moravec wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17592/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 2:15 p.m.) > > > Review request for qpid, Chug Rolke, Cliff Jansen, Kim van der Riet, and > Steve Huston. > > > Bugs: QPID-5531 > https://issues.apache.org/jira/browse/QPID-5531 > > > Repository: qpid > > > Description > ------- > > If a rogue external Transaction Manager forgets to commit/rollback a prepared > DTX, Tpl store keeps an orphaned enqueue record. To prevent it, every DTX > transaction should have a default timeout after that the broker automatically > aborts the transaction. > > QPID-5531 adds broker option dtx-default-timeout for that. > > My concerns for review: > - is 3600 seconds as default value proper? Isn't it too high? > - ms-sql and/or ms-clfs store part of the patch (recoverTransaction method) > has not been even compiled > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Broker.h 1563872 > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1563872 > /trunk/qpid/cpp/src/qpid/broker/DtxManager.h 1563872 > /trunk/qpid/cpp/src/qpid/broker/DtxManager.cpp 1563872 > /trunk/qpid/cpp/src/qpid/broker/SessionAdapter.cpp 1563872 > /trunk/qpid/cpp/src/tests/qpid-txtest.cpp 1563872 > /trunk/qpid/tests/src/py/qpid_tests/broker_0_10/dtx.py 1563872 > > Diff: https://reviews.apache.org/r/17592/diff/ > > > Testing > ------- > > > Thanks, > > Pavel Moravec > >
