----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18627/#review35784 -----------------------------------------------------------
Ship it! Ship It! - Rafael Schloming On Feb. 28, 2014, 2:49 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18627/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2014, 2:49 p.m.) > > > Review request for qpid, Gordon Sim and Rafael Schloming. > > > Bugs: qpid-5588 > https://issues.apache.org/jira/browse/qpid-5588 > > > Repository: qpid > > > Description > ------- > > select() is limited to file descriptors whose value is < FD_SETSIZE. poll() > does not have this limitation, and thus can support applications with large # > of open file descriptors. > > > Diffs > ----- > > /trunk/qpid/python/qpid/compat.py 1572933 > > Diff: https://reviews.apache.org/r/18627/diff/ > > > Testing > ------- > > unit tests + tested opening a large # of simultaneous connections (with > patch: > 1300 connections before system limit hit, w/o patch: ~300 before > select failed due to fd > FD_SETSIZE) > > > Thanks, > > Kenneth Giusti > >
