----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18649/#review36015 -----------------------------------------------------------
Ship it! Looks good to me with one small change: please adjust the leady spaces for the changed line so that it lines up as before the edit. - Darryl Pierce On March 3, 2014, 7:27 p.m., Chug Rolke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18649/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 7:27 p.m.) > > > Review request for qpid and Darryl Pierce. > > > Bugs: qpid-5589 > https://issues.apache.org/jira/browse/qpid-5589 > > > Repository: qpid > > > Description > ------- > > Depending on where Python is installed on windows then qpid 'make install' > fails. This patch > > 1. Makes the install optional. > 2. Escapes spaces in the install path name so that installations to "Program > Files" work. > > > Diffs > ----- > > trunk/qpid/cpp/managementgen/CMakeLists.txt 1573098 > > Diff: https://reviews.apache.org/r/18649/diff/ > > > Testing > ------- > > Installation can be skipped using the option. Installation succeeds with > space in python path name. > > > Thanks, > > Chug Rolke > >
