-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18900/
-----------------------------------------------------------

Review request for qpid, Gordon Sim and Kenneth Giusti.


Bugs: QPID-5608
    https://issues.apache.org/jira/browse/QPID-5608


Repository: qpid


Description
-------

The fix follows how IncomingToQueue class behave here for queues. Potential 
issues with the fix (causing me to raise the review request before committing 
it):

1) change in Exchange::decOtherUsers - cant it be done in more elegant way?
2) can't the petch in general cause problems to some other lifetime policies?


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/Exchange.h 1574030 
  /trunk/qpid/cpp/src/qpid/broker/Exchange.cpp 1574030 
  /trunk/qpid/cpp/src/qpid/broker/amqp/Session.cpp 1574030 

Diff: https://reviews.apache.org/r/18900/diff/


Testing
-------

automated tests seem passed, the reproducer from JIRA is fixed


Thanks,

Pavel Moravec

Reply via email to