-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19199/
-----------------------------------------------------------
Review request for qpid and Gordon Sim.
Bugs: QPID-5623
https://issues.apache.org/jira/browse/QPID-5623
Repository: qpid
Description
-------
This patch intercepts any qpid::Exception traps that are not types::Exception
and rethrows them as messaging::ConnectionError.
The issue was first noted using amqp1.0 as it is handled correctly in amqp0-10.
This code could be moved to other places in amqp1.0 handlers such as
ConnectionHandle.cpp:52 and ConnectionContext.cpp:89. However, there the
try/catch would be inserted into constructor initialization lists where it
looks ugly and is hard to read.
Diffs
-----
trunk/qpid/cpp/src/qpid/messaging/amqp/ConnectionHandle.cpp 1577280
Diff: https://reviews.apache.org/r/19199/diff/
Testing
-------
Linux client/broker from command line.
Thanks,
Chug Rolke
