[
https://issues.apache.org/jira/browse/QPID-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943992#comment-13943992
]
Rob Godfrey commented on QPID-5640:
-----------------------------------
I've not looked at this in great detail... but I think it highlights a couple
of issues
1) the API for the config store is wrong - it views all configured objects as a
tuple: (UUID id, String type, Map<String, Object> attributes) but parents are
not really "attributes".
2) The implementation of Binding has been abused to make the parents also
appear as attributes, but this is not really correct. Moreover the type of
these attributes was being relied on by the Json store implementation, but the
type was not tested in the store itself
For the current release we at least need to restore the ability of bindings to
be persisted, however for following releases I think getting the API correct is
necessary. I think this is covered by QPID-5615, but it does raise the
question as to how deeply the configuration stores should understand
ConfiguredObjects. My going in position is probably still that the store
should remain unaware of configured objects and should really only be aware of
basic types + UUID.
The store notion of an object would then be something like (UUID id, String
type, Map<String, UUID> parents, Map<String, Object> attributes) where parents
is a map from parent type to id.
> JsonFileConfigStore does not save bindings
> ------------------------------------------
>
> Key: QPID-5640
> URL: https://issues.apache.org/jira/browse/QPID-5640
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.28, 0.29
> Reporter: Keith Wall
>
> The JsonFileConfigStore does not persist exchange bindings to the json file.
> Queues and Exchanges are persisted, but their bindings are absent.
> The JsonFileConfigStoreTest should be strengthen.
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
