----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20122/ -----------------------------------------------------------
Review request for qpid. Bugs: QPID-5669 https://issues.apache.org/jira/browse/QPID-5669 Repository: qpid Description ------- This fix does the following: It moves all testing for self-delete to the IO thread by means of a reaper callback. It frees the SChannel encrypt/decrypt resources in the queueForDeletion() method which guarantees that the resources are freed at the last point they can safely be done without the transport layer's own destructor cleaning up associated resources out of order. If forces a single "winner" between close and disconnect (see QPID-5668). This results in a small performance penalty on connection teardown, while allowing a tiny performance win in ordinary read processing. Diffs ----- http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/AsynchIO.cpp 1585645 http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.h 1585645 http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/SslAsynchIO.cpp 1585645 Diff: https://reviews.apache.org/r/20122/diff/ Testing ------- Windows 7, 32/64 bit clients, amqp1.0 and amqp0-10, C++ and C#, wifi/wired connections. Thanks, Cliff Jansen