[ 
https://issues.apache.org/jira/browse/QPID-5685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967667#comment-13967667
 ] 

Rob Godfrey edited comment on QPID-5685 at 4/12/14 10:21 PM:
-------------------------------------------------------------

Out of interest... is there any reason to retain the begin() and end() methods 
on the visitor/handler?

where you previously might have

{code}
visitConfiguredObjectRecords(foo); 
{code}

you could replace that with

{code}
foo.begin();
visitConfiguredObjectRecords(foo); 
foo.end();
{code}

and then inline / move whatever code was in the begin/end methods to a more 
sensible place



was (Author: rgodfrey):
Out of interest... is there any reason to retain the begin() and end() methods 
on the visitor/handler?

where you previous might have

{code}
visitConfiguredObjectRecords(foo); 
{code}

you could replace that with

{code}
foo.begin();
visitConfiguredObjectRecords(foo); 
foo.end();
{code}

and then inline / move whatever code was in the begin/end methods to a more 
sensible place


> Store config version as an attribute of virtualhost within configuration store
> ------------------------------------------------------------------------------
>
>                 Key: QPID-5685
>                 URL: https://issues.apache.org/jira/browse/QPID-5685
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: 
> 0001-QPID-5685-Store-configuration-version-as-an-attribut.patch
>
>
> Currently the Derby and BDB stores store the configuration version (the 
> version number that describes the format of the configuration objects) within 
> a separate table/database.
> It has been decided to the move this configuration version information into 
> the configuration store itself.  It will reside as a modelVersion attribute 
> on a new VirtualHost record.
> This commit will change the structure of the stores to eliminate the 
> config_version table/database. Store upgraders produce the virtualhost 
> record, populating the version from version number in table, prepending "0.". 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to