----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20579/#review41129 -----------------------------------------------------------
Ship it! Looks ok to me. - Gordon Sim On April 22, 2014, 10:01 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20579/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:01 p.m.) > > > Review request for qpid, Gordon Sim and Justin Ross. > > > Repository: qpid > > > Description > ------- > > RFI 0.28: QPID-5711: HA cannot promote primary if SASL security is enabled. > > Updated the qpid-ha tool and qpidd init scripts to handle SASL authentication. > The qpid-ha script as as called by the qpidd-primary init script now reads > authentication settings from the qpidd.conf file and uses them to connect to > the local broker. > > - qpidd-primary script respects prefix: use installed location for qpidd > script, not "service" call > - qpid-ha added --config option qpid-ha options to use qpidd.conf for local > broker connection. > - qpid-ha --all use user/pass for each broker. > > > Diffs > ----- > > /trunk/qpid/cpp/etc/CMakeLists.txt 1588468 > /trunk/qpid/cpp/etc/qpidd-primary.in 1588468 > /trunk/qpid/cpp/etc/qpidd.in 1588468 > /trunk/qpid/tools/src/py/qpid-ha 1588468 > /trunk/qpid/tools/src/py/qpidtoollibs/config.py PRE-CREATION > > Diff: https://reviews.apache.org/r/20579/diff/ > > > Testing > ------- > > Tested on a security-enabled 3 node cluster. No automated tests added. > Running full ctest. > > > Thanks, > > Alan Conway > >
