[
https://issues.apache.org/jira/browse/QPID-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980024#comment-13980024
]
Keith Wall commented on QPID-5698:
----------------------------------
Hi Rob
I've reviewed commits r1587262 , r1587266, r1587367, r1587682 and r1588667
against this Jira, I have only minor comments:
# AccessControlProvider, AuthenticationProvider, Connection, Consumer:,
Exchange, Group, GroupMember, GroupProvider, KeyStore, Session, TrustStore:
duplication of constants from ConfiguredObject (TYPE, DESCRIPTION, STATE etc)
# AbstractConfiguredObject. Message "ManagedAttributes must be either
automated or derived." should include "or state" though I expect the state
annotation is going to die in its current form.
> [Java Broker] Move all configured attributes to be either automated or derived
> ------------------------------------------------------------------------------
>
> Key: QPID-5698
> URL: https://issues.apache.org/jira/browse/QPID-5698
> Project: Qpid
> Issue Type: Sub-task
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
>
> Move all configured object attributes to be either automated (meaning that
> the base class handles the setting and thus performs defaulting and
> interpolation) or derived (which means that the attribute cannot be set and
> responsibility for providing the value is left to the implementation class).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
