[
https://issues.apache.org/jira/browse/QPID-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982882#comment-13982882
]
Alex Rudyy commented on QPID-5679:
----------------------------------
My review comments:
Redundant re-declration of a methods on AMQQueue interface( they are already
declared on model Queue interface)
org.apache.qpid.server.queue.AMQQueue.getMaximumDeliveryAttempts()
org.apache.qpid.server.queue.AMQQueue.getPersistentDequeuedBytes()
org.apache.qpid.server.queue.AMQQueue.getPersistentDequeuedMessages()
org.apache.qpid.server.queue.AMQQueue.getPersistentEnqueuedBytes()
org.apache.qpid.server.queue.AMQQueue.getPersistentEnqueuedMessages()
org.apache.qpid.server.queue.AMQQueue.getTotalDequeuedBytes()
org.apache.qpid.server.queue.AMQQueue.getTotalDequeuedBytes()
org.apache.qpid.server.queue.AMQQueue.getUnacknowledgedMessages()
org.apache.qpid.server.queue.AMQQueue.getAttribute(String)
org.apache.qpid.server.queue.AMQQueue.visit(QueueEntryVisitor)
org.apache.qpid.server.queue.AMQQueue.delete()
org.apache.qpid.server.queue.AMQQueue.getQueueDepthBytes()
org.apache.qpid.server.queue.AMQQueue.getQueueDepthMessages()
org.apache.qpid.server.queue.AMQQueue.getConsumerCountWithCredit()
org.apache.qpid.server.queue.AMQQueue.getConsumers()
org.apache.qpid.server.queue.AMQQueue.getConsumerCount()
org.apache.qpid.server.queue.AMQQueue.getTotalEnqueuedMessages()
org.apache.qpid.server.queue.AMQQueue.getTotalDequeuedMessages()
org.apache.qpid.server.queue.AMQQueue.getUnacknowledgedBytes()
org.apache.qpid.server.queue.AMQQueue.getBindingCount()
org.apache.qpid.server.queue.AMQQueue.getBindings()
Misleading comment on
org.apache.qpid.server.queue.AbstractQueue._exclusiveOwner
Comment states that it "could be connection, session or Principal" but it also
can be String for exclusive policy set to ExclusivityPolicy.CONTAINER
I am wondering whether the following block from AbstractQueue#onOpen belongs to
AbstractQueue#validate()?
if (_queueFlowResumeSizeBytes > _queueFlowControlSizeBytes)
{
throw new IllegalConfigurationException("Flow resume size can't be
greater than flow control size");
}
> [Java Broker] Use interpolation for "inherited" attributes (such as queue
> alerting)
> -----------------------------------------------------------------------------------
>
> Key: QPID-5679
> URL: https://issues.apache.org/jira/browse/QPID-5679
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.29
>
>
> Currently we shadow alerting settings in virtual hosts and brokers to allow
> site wide defaults to be set.
> Instead define the default at the queue to be "$\{<name>\}", which can then
> be overridden at the vhost or broker level (or on the command line).
> Additionally allow the setting of "default" values for context variables
> which are used if nothing is set in a parent, java system properties or the
> environment.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
