----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21267/#review42816 -----------------------------------------------------------
Ship it! Seems fine for me, ship it! (and thanks for the fix) - Pavel Moravec On May 12, 2014, 2:17 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21267/ > ----------------------------------------------------------- > > (Updated May 12, 2014, 2:17 p.m.) > > > Review request for qpid, Alan Conway and Pavel Moravec. > > > Bugs: QPID-5758 > https://issues.apache.org/jira/browse/QPID-5758 > > > Repository: qpid > > > Description > ------- > > Uses a PollableQueue to have queues purged by worker threads rather than > doing it on the timer thread which may affect other tasks. > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Broker.cpp 1593267 > /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.h 1593267 > /trunk/qpid/cpp/src/qpid/broker/QueueCleaner.cpp 1593267 > /trunk/qpid/cpp/src/tests/QueueTest.cpp 1593267 > > Diff: https://reviews.apache.org/r/21267/diff/ > > > Testing > ------- > > make test passes; some manual testing of expiration also > > > Thanks, > > Gordon Sim > >
