[
https://issues.apache.org/jira/browse/QPID-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14017527#comment-14017527
]
Keith Wall commented on QPID-5715:
----------------------------------
Hi Alex
If the user mutates the replication attributes whilst work it in flight, it
looks like you have organised it so that existing CommitFutures are processed.
This looks like a reasonable approach, however, any remaining commit-futures
are going to be processed by the model's task executor (the thread calling
CoalescingCommitter#stop), rather than the commit thread. I wonder if the
algorithm for BDBCommitFuture#run were changed so that after has detected
shutdown, it has one more go (i.e. calls processJobs again) if jobs remain, the
need for the call to processJobs within BDBCommitFuture#stop can be avoided.
In that way, all syncs will always be performed by the commit thread making the
system easier to reason about. What do you think?
Separately, I wonder if the commit thread should be daemon?
Still some constants REMOTE_TRANSACTION_SYNCRONIZATION_POLICY etc are misspelt
(missing h).
> [Java Broker] Introduce VirtualHostNode into model
> --------------------------------------------------
>
> Key: QPID-5715
> URL: https://issues.apache.org/jira/browse/QPID-5715
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Broker
> Reporter: Keith Wall
> Assignee: Keith Wall
> Attachments:
> 0001-QPID-5715-Java-Broker-Make-virtualhosts-respect-the-.patch
>
>
> In order to support the HA use-case, a new object, VirtualHostNode will be
> added into the Broker model. The Broker will support zero or more virtual
> host nodes. Each virtual host node may have zero or one virtual hosts.
> Virtualhostnode will be responsible for
> * the lifecycle of the durable configuration store
> * the recovery of its children (that is, the virtual host and its object
> descendants (exchanges, queues etc) but not messages/message instances etc).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
