-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22724/
-----------------------------------------------------------
Review request for qpid, Alan Conway, Kenneth Giusti, and Rafael Schloming.
Bugs: QPID-5830
https://issues.apache.org/jira/browse/QPID-5830
Repository: qpid
Description
-------
Two potential issues:
1) Does it makes sense to create binding if the node already exists? In my
opinion yes, as a) C++ client does so, b) an application does not know if the
node already exists or not, but relies on having the node _and_ the binding
created, at the end. So regardless of node created or not, the client should
create the binding.
2) I am not sure if the way I "grafted" the change in source code is optimal.
It works, anyway, and no tests failed.
Diffs
-----
/trunk/qpid/python/qpid/messaging/driver.py 1596542
Diff: https://reviews.apache.org/r/22724/diff/
Testing
-------
Automated tests passed.
Both use cases (exchange existed, queue existed) fixed.
Thanks,
Pavel Moravec